maket/MaketRandevu
1
1
Fork 0
Code Issues 15 Pull requests Projects Releases 4 Packages Wiki Activity

Corrected working plan event handling that was failing due to invalid relative selectors (fixes #218).

Browse source
This commit is contained in:
alextselegidis 2016-10-23 21:52:36 +02:00
parent 2a775bcfb6
commit 8a9a3b2192
1 changed files with 10 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/assets/js/working_plan.js
View file

@ -268,12 +268,13 @@
*/ */
$(document).on('click', '.cancel-break', function(e) { $(document).on('click', '.cancel-break', function(e) {
var element = e.target; var element = e.target;
var $modifiedRow = $(element).closest('tr');
this.enableCancel = true; this.enableCancel = true;
$(element).parent().parent().find('.cancel-editable').trigger('click'); $modifiedRow.find('.cancel-editable').trigger('click');
this.enableCancel = false; this.enableCancel = false;
$(element).closest('table').find('.edit-break, .delete-break').removeClass('hidden'); $(element).closest('table').find('.edit-break, .delete-break').removeClass('hidden');
$(element).parent().find('.save-break, .cancel-break').addClass('hidden'); $modifiedRow.find('.save-break, .cancel-break').addClass('hidden');
$('.add-break').prop('disabled', false); $('.add-break').prop('disabled', false);
}.bind(this)); }.bind(this));
@ -283,25 +284,23 @@
* Save the editable values and restore the table to its initial state. * Save the editable values and restore the table to its initial state.
* *
* @param {jQuery.Event} e * @param {jQuery.Event} e
*
* @todo: Prevent from adding interrelated breaks
*/ */
$(document).on('click', '.save-break', function(e) { $(document).on('click', '.save-break', function(e) {
// Break's start time must always be prior to break's end. // Break's start time must always be prior to break's end.
var element = e.target, var element = e.target,
$editedTr = $(element).closest('tr'), $modifiedRow = $(element).closest('tr'),
start = Date.parse($editedTr.find('.break-start input').val()), start = Date.parse($modifiedRow.find('.break-start input').val()),
end = Date.parse($editedTr.find('.break-end input').val()); end = Date.parse($modifiedRow.find('.break-end input').val());
if (start > end) { if (start > end) {
$editedTr.find('.break-end input').val(start.addHours(1).toString('HH:mm')); $modifiedRow.find('.break-end input').val(start.addHours(1).toString('HH:mm'));
} }
this.enableSubmit = true; this.enableSubmit = true;
$editedTr.find('.editable .submit-editable').trigger('click'); $modifiedRow.find('.editable .submit-editable').trigger('click');
this.enableSubmit = false; this.enableSubmit = false;
$editedTr.find('.save-break, .cancel-break').addClass('hidden'); $modifiedRow.find('.save-break, .cancel-break').addClass('hidden');
$(element).closest('table').find('.edit-break, .delete-break').removeClass('hidden'); $(element).closest('table').find('.edit-break, .delete-break').removeClass('hidden');
$('.add-break').prop('disabled', false); $('.add-break').prop('disabled', false);
}.bind(this)); }.bind(this));
@ -311,8 +310,6 @@
* Get the working plan settings. * Get the working plan settings.
* *
* @return {Object} Returns the working plan settings object. * @return {Object} Returns the working plan settings object.
*
* @todo: Add sorting by range within day breaks
*/ */
WorkingPlan.prototype.get = function() { WorkingPlan.prototype.get = function() {
var workingPlan = {}; var workingPlan = {};
@ -455,4 +452,4 @@
window.WorkingPlan = WorkingPlan; window.WorkingPlan = WorkingPlan;
})(); })();