From e96d455c644a21dfa1c17f1264a68a5bb17b0234 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Wed, 27 Nov 2019 19:24:15 +0100 Subject: [PATCH] Add notes about this firewall thing which is creating security issues if you don't need it ... --- scripts/install | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/scripts/install b/scripts/install index bca2fd3..4da9fc8 100755 --- a/scripts/install +++ b/scripts/install @@ -87,12 +87,16 @@ ynh_script_progression --message="Configuring firewall..." --time --weight=1 ### If you're not using these lines: ### - Remove the section "CLOSE A PORT" in the remove script -# Find a free port +# Find an available port port=$(ynh_find_port --port=8095) -# Open this port -ynh_exec_warn_less yunohost firewall allow --no-upnp TCP $port ynh_app_setting_set --app=$app --key=port --value=$port +# Optional: Expose this port publicly +# (N.B. : you only need to do this if the app actually needs to expose the port publicly. +# If you do this and the app doesn't actually need you are CREATING SECURITY HOLES IN THE SERVER !) +# ynh_exec_warn_less yunohost firewall allow --no-upnp TCP $port + + #================================================= # INSTALL DEPENDENCIES #=================================================